Skip to content

Add CustomEventTrace - #979

Merged
Kyle-Ye merged 5 commits into
OpenSwiftUIProject:mainfrom
Dark-Existed:feature/custom_event_trace
Aug 9, 2026
Merged

Add CustomEventTrace#979
Kyle-Ye merged 5 commits into
OpenSwiftUIProject:mainfrom
Dark-Existed:feature/custom_event_trace

Conversation

@Dark-Existed

Copy link
Copy Markdown
Contributor

No description provided.

@Dark-Existed
Dark-Existed requested a review from Kyle-Ye as a code owner August 4, 2026 11:27
Comment thread Sources/OpenSwiftUICore/Tracing/CustomEventTrace.swift Outdated
Comment thread Sources/OpenSwiftUICore/Tracing/CustomEventTrace.swift
Comment thread Sources/OpenSwiftUICore/Tracing/CustomEventTrace.swift Outdated
Comment thread Sources/OpenSwiftUICore/Tracing/CustomEventTrace.swift Outdated
Comment thread Sources/OpenSwiftUICore/Tracing/CustomEventTrace.swift Outdated
Comment thread Sources/OpenSwiftUICore/Tracing/CustomEventTrace.swift Outdated
@Kyle-Ye Kyle-Ye added this to the 0.21.0 milestone Aug 4, 2026 — with ChatGPT Codex Connector
@Kyle-Ye Kyle-Ye added area: event-gesture Events, gestures, tracing, or interaction plumbing. type: feature New API, behavior, platform support, or user-facing capability. labels Aug 4, 2026 — with ChatGPT Codex Connector
@Dark-Existed
Dark-Existed force-pushed the feature/custom_event_trace branch from 812c5b7 to 91fd7dc Compare August 5, 2026 00:04
@Dark-Existed

Copy link
Copy Markdown
Contributor Author

All done.

@Dark-Existed

Copy link
Copy Markdown
Contributor Author

Wait... I forgot that OSAtomicAdd32 is Darwin-only.

I’m considering adding _incrementTraceIDThreadSafe to OpenSwiftUI_SPI as replacement.
Any suggestions?

@Dark-Existed
Dark-Existed force-pushed the feature/custom_event_trace branch 2 times, most recently from 4e1d7c9 to d560ab7 Compare August 5, 2026 14:45
@Kyle-Ye

Kyle-Ye commented Aug 9, 2026

Copy link
Copy Markdown
Member

Wait... I forgot that OSAtomicAdd32 is Darwin-only.

I’m considering adding _incrementTraceIDThreadSafe to OpenSwiftUI_SPI as replacement. Any suggestions?

We can use Atomic API here. Don't worry, I'll review and complete the missing part today.

@Kyle-Ye
Kyle-Ye force-pushed the feature/custom_event_trace branch from d560ab7 to fe09508 Compare August 9, 2026 13:11
@Kyle-Ye
Kyle-Ye merged commit 52ad90d into OpenSwiftUIProject:main Aug 9, 2026
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: event-gesture Events, gestures, tracing, or interaction plumbing. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants