Skip to content

Update DisplayList expectations after canonicalization - #996

Merged
Kyle-Ye merged 1 commit into
mainfrom
bugfix/dl
Aug 15, 2026
Merged

Update DisplayList expectations after canonicalization#996
Kyle-Ye merged 1 commit into
mainfrom
bugfix/dl

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Aug 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Update variadic view DisplayList expectations to match canonicalized effect nesting.
  • Match view-alias output as direct color items after redundant effects are removed.
  • Remove the obsolete effect-wrapped color helper.

Root Cause

DisplayList canonicalization removes redundant effect nodes, while these tests still matched the pre-canonicalized structure. This caused seven assertion failures even though the rendered colors were correct.

Validation

  • ViewAliasTests and VariadicViewTests: 7 tests passed with Swift 6.3.3 / Xcode 26.6.

@github-actions github-actions Bot added area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: tests Test coverage, test infrastructure, snapshots, or test-only changes. labels Aug 15, 2026
@Kyle-Ye
Kyle-Ye marked this pull request as ready for review August 15, 2026 18:37
@tuist

tuist Bot commented Aug 15, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 82 0 82 e953587fd

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 1m 36s e953587fd

@Kyle-Ye
Kyle-Ye merged commit 76597a1 into main Aug 15, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/dl branch August 15, 2026 18:46
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.25%. Comparing base (593f544) to head (aae91ad).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #996       +/-   ##
===========================================
+ Coverage   14.29%   26.25%   +11.95%     
===========================================
  Files         691      734       +43     
  Lines       48857    55580     +6723     
===========================================
+ Hits         6983    14590     +7607     
+ Misses      41874    40990      -884     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: rendering DisplayList, render backends, renderer hosts, drawing, and effects. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: tests Test coverage, test infrastructure, snapshots, or test-only changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant