Skip to content

Codefix: Rename breakdown setting value string - #15908

Merged
2TallTyler merged 1 commit into
OpenTTD:masterfrom
2TallTyler:rename-breakdown-string
Jul 25, 2026
Merged

Codefix: Rename breakdown setting value string#15908
2TallTyler merged 1 commit into
OpenTTD:masterfrom
2TallTyler:rename-breakdown-string

Conversation

@2TallTyler

Copy link
Copy Markdown
Member

Motivation / Problem

The value strings for the vehicle breakdowns setting have the prefix DISASTER, but the strings are only used for breakdowns. Disasters are boolean settings, so they have no value strings.

(I am working on something that touches these strings, but this is wrong so I see no reason why we shouldn't just fix it anyway.)

Description

Rename the strings in all languages to say BREAKDOWNS without changing their contents. (As per the eints docs, this is allowed.)

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@2TallTyler 2TallTyler changed the title Codechange: Rename breakdown setting value string Codefix: Rename breakdown setting value string Jul 25, 2026
@2TallTyler
2TallTyler force-pushed the rename-breakdown-string branch from 5df0a54 to dcb73da Compare July 25, 2026 14:38
@2TallTyler
2TallTyler merged commit 1f981d5 into OpenTTD:master Jul 25, 2026
18 checks passed
@2TallTyler
2TallTyler deleted the rename-breakdown-string branch July 25, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants