Codefix: Rename breakdown setting value string - #15908
Merged
Merged
Conversation
2TallTyler
force-pushed
the
rename-breakdown-string
branch
from
July 25, 2026 14:38
5df0a54 to
dcb73da
Compare
rubidium42
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The value strings for the vehicle breakdowns setting have the prefix
DISASTER, but the strings are only used for breakdowns. Disasters are boolean settings, so they have no value strings.(I am working on something that touches these strings, but this is wrong so I see no reason why we shouldn't just fix it anyway.)
Description
Rename the strings in all languages to say
BREAKDOWNSwithout changing their contents. (As per the eints docs, this is allowed.)Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.