Skip to content

[OT-181] [FIX]: 모니터링 배포 스크립트의 env 생성 및 compose 실행 호환성 수정#103

Merged
arlen02-01 merged 1 commit intodevelopfrom
OT-181-chore/monitoring
Mar 4, 2026
Merged

[OT-181] [FIX]: 모니터링 배포 스크립트의 env 생성 및 compose 실행 호환성 수정#103
arlen02-01 merged 1 commit intodevelopfrom
OT-181-chore/monitoring

Conversation

@arlen02-01
Copy link
Copy Markdown
Contributor

@arlen02-01 arlen02-01 commented Mar 4, 2026

📝 작업 내용

이번 PR에서 작업한 내용을 적어주세요

  • 깃 액션 컴파일 오류 수정

☑️ 체크 리스트

체크 리스트를 확인해주세요

  • 테스트는 잘 통과했나요?
  • 충돌을 해결했나요?
  • 이슈는 등록했나요?
  • 라벨은 등록했나요?

#️⃣ 연관된 이슈

ex) # 이슈번호
#102

Summary by CodeRabbit

릴리스 노트

  • Chores
    • 배포 자동화의 안정성 및 호환성 개선

참고: 이 변경 사항은 내부 배포 인프라 개선으로, 최종 사용자에게 직접적인 기능 변화가 없습니다.

@arlen02-01 arlen02-01 added the fix 버그 수정 label Mar 4, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 4, 2026

Walkthrough

.github/workflows/deploy-monitoring.yml 파일이 수정되어 Docker Compose 환경 초기화 방식이 개선되었습니다. .env 파일 생성 접근 방식이 통합되었고, docker compose 또는 docker-compose 바이너리 감지 후 조건부 실행 로직이 추가되었으며, 두 바이너리 모두 없을 경우 명시적 오류 처리가 구현되었습니다.

Changes

Cohort / File(s) Summary
Docker Compose 초기화 로직 개선
.github/workflows/deploy-monitoring.yml
Grafana 환경 변수 파일 생성을 printf와 tee를 사용한 통합 방식으로 변경. docker compose/docker-compose 바이너리 자동 감지 조건부 로직 추가. 적절한 COMPOSE_CMD 설정 후 --env-file 옵션과 함께 사용. 호환성 확보 및 오류 처리 강화.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

deploy

Suggested reviewers

  • marulog
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 변경 사항의 주요 내용을 명확하게 요약하고 있습니다. 모니터링 배포 스크립트의 env 생성 및 docker-compose 호환성 수정이라는 핵심 변경 사항을 정확하게 반영하고 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch OT-181-chore/monitoring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arlen02-01 arlen02-01 requested a review from marulog March 4, 2026 05:14
Copy link
Copy Markdown
Collaborator

@marulog marulog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/deploy-monitoring.yml:
- Line 163: The current use of the --arg c9 "printf ...
'GF_SECURITY_ADMIN_PASSWORD=${GRAFANA_PASSWORD}' | sudo tee
${MONITORING_ROOT}/.env" is vulnerable to shell-breaking/injection if
GRAFANA_PASSWORD contains quotes or newlines; change the approach to build the
.env content locally, base64-encode it (including GF_SECURITY_ADMIN_USER and
GF_SECURITY_ADMIN_PASSWORD), pass the encoded string (instead of raw password
interpolation) via the existing arg (e.g., the arg name c9), and on the remote
side decode the base64 into ${MONITORING_ROOT}/.env with a safe write (e.g.,
echo <base64> | base64 --decode | sudo tee ${MONITORING_ROOT}/.env), ensuring
you stop interpolating GRAFANA_PASSWORD directly in the remote shell and
reference MONITORING_ROOT and the arg c9 in the updated commands.

ℹ️ Review info
Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 055b7d45-eac5-4c6c-adea-4934ea61d42f

📥 Commits

Reviewing files that changed from the base of the PR and between 45b9a6b and 8aa628a.

📒 Files selected for processing (1)
  • .github/workflows/deploy-monitoring.yml

Comment thread .github/workflows/deploy-monitoring.yml
@arlen02-01 arlen02-01 merged commit 5a94a0e into develop Mar 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 버그 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants