[OT-181] [FIX]: 모니터링 배포 스크립트의 env 생성 및 compose 실행 호환성 수정#103
Merged
arlen02-01 merged 1 commit intodevelopfrom Mar 4, 2026
Merged
[OT-181] [FIX]: 모니터링 배포 스크립트의 env 생성 및 compose 실행 호환성 수정#103arlen02-01 merged 1 commit intodevelopfrom
arlen02-01 merged 1 commit intodevelopfrom
Conversation
Walkthrough
Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/deploy-monitoring.yml:
- Line 163: The current use of the --arg c9 "printf ...
'GF_SECURITY_ADMIN_PASSWORD=${GRAFANA_PASSWORD}' | sudo tee
${MONITORING_ROOT}/.env" is vulnerable to shell-breaking/injection if
GRAFANA_PASSWORD contains quotes or newlines; change the approach to build the
.env content locally, base64-encode it (including GF_SECURITY_ADMIN_USER and
GF_SECURITY_ADMIN_PASSWORD), pass the encoded string (instead of raw password
interpolation) via the existing arg (e.g., the arg name c9), and on the remote
side decode the base64 into ${MONITORING_ROOT}/.env with a safe write (e.g.,
echo <base64> | base64 --decode | sudo tee ${MONITORING_ROOT}/.env), ensuring
you stop interpolating GRAFANA_PASSWORD directly in the remote shell and
reference MONITORING_ROOT and the arg c9 in the updated commands.
ℹ️ Review info
Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 055b7d45-eac5-4c6c-adea-4934ea61d42f
📒 Files selected for processing (1)
.github/workflows/deploy-monitoring.yml
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
☑️ 체크 리스트
#️⃣ 연관된 이슈
Summary by CodeRabbit
릴리스 노트
참고: 이 변경 사항은 내부 배포 인프라 개선으로, 최종 사용자에게 직접적인 기능 변화가 없습니다.