Skip to content

[OT-181] [FIX]: 모니터링 배포 과정에서 필요 파일 있을 시 실패->다운받기 로 변경#104

Merged
arlen02-01 merged 1 commit intodevelopfrom
OT-181-chore/monitoring
Mar 4, 2026
Merged

[OT-181] [FIX]: 모니터링 배포 과정에서 필요 파일 있을 시 실패->다운받기 로 변경#104
arlen02-01 merged 1 commit intodevelopfrom
OT-181-chore/monitoring

Conversation

@arlen02-01
Copy link
Copy Markdown
Contributor

@arlen02-01 arlen02-01 commented Mar 4, 2026

📝 작업 내용

이번 PR에서 작업한 내용을 적어주세요

  • 모니터링 배포 과정에서 필요 파일 있을 시 실패->다운받기 로 변경

☑️ 체크 리스트

체크 리스트를 확인해주세요

  • 테스트는 잘 통과했나요?
  • 충돌을 해결했나요?
  • 이슈는 등록했나요?
  • 라벨은 등록했나요?

#️⃣ 연관된 이슈

ex) # 이슈번호
#103

Summary by CodeRabbit

릴리스 노트

  • 개선 사항
    • 배포 프로세스의 Docker Compose 감지 및 설치 메커니즘이 강화되었습니다. 다단계 폴백 처리를 통해 여러 설치 방법을 자동으로 시도하여 배포 신뢰성이 향상되었습니다.

@arlen02-01 arlen02-01 requested a review from marulog March 4, 2026 05:40
@arlen02-01 arlen02-01 self-assigned this Mar 4, 2026
@arlen02-01 arlen02-01 added the fix 버그 수정 label Mar 4, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 4, 2026

Walkthrough

GitHub Actions deploy-monitoring 워크플로우의 c10 단계에서 Docker Compose 감지 로직이 확장되었습니다. 기존의 단순 존재 여부 확인에서 dnf/yum을 통한 설치 시도 및 바이너리 다운로드를 포함한 다단계 폴백 설치 흐름으로 변경되었습니다.

Changes

Cohort / File(s) Summary
GitHub Actions 워크플로우
.github/workflows/deploy-monitoring.yml
c10 단계의 docker compose 감지 명령어를 다단계 폴백 설치 흐름으로 확장. dnf/yum 패키지 설치 시도 추가, 실패 시 바이너리를 /usr/local/lib/docker/cli-plugins에 다운로드하여 실행 권한 부여 후 재확인.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • marulog
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목은 모니터링 배포 과정에서 Docker Compose 파일 누락 시 실패하지 않고 다운로드하도록 변경하는 내용을 명확하게 요약하고 있으며, 실제 changeset의 주요 변경사항과 일치합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch OT-181-chore/monitoring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@marulog marulog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 :)

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/deploy-monitoring.yml:
- Line 164: The c10 multi-line arg currently unconditionally downloads
docker-compose-linux-x86_64 and makes it executable without integrity checks;
change it to detect architecture using uname -m in the c10 logic, map
x86_64→docker-compose-linux-x86_64 and
aarch64/arm64→docker-compose-linux-aarch64, download both the matching binary
and the release's checksums.txt for Docker Compose v2.29.7, verify the
downloaded binary with sha256sum (or shasum -a 256) against checksums.txt before
running sudo chmod +x and placing it in /usr/local/lib/docker/cli-plugins, and
fail with an error if the checksum verification or download fails.

ℹ️ Review info
Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ab85e329-0c8d-4769-a849-0cf734df7ad1

📥 Commits

Reviewing files that changed from the base of the PR and between 34e6e49 and 37282c0.

📒 Files selected for processing (1)
  • .github/workflows/deploy-monitoring.yml

Comment thread .github/workflows/deploy-monitoring.yml
@arlen02-01 arlen02-01 merged commit 4c2c5da into develop Mar 4, 2026
1 check passed
@phonil phonil deleted the OT-181-chore/monitoring branch April 4, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 버그 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants