Skip to content

[FEAT]: 서브 domain 허용#223

Merged
marulog merged 1 commit intodevelopfrom
OT-369-feature/seperate-JWT
Mar 23, 2026
Merged

[FEAT]: 서브 domain 허용#223
marulog merged 1 commit intodevelopfrom
OT-369-feature/seperate-JWT

Conversation

@marulog
Copy link
Copy Markdown
Collaborator

@marulog marulog commented Mar 23, 2026

📝 작업 내용

이번 PR에서 작업한 내용을 적어주세요

  • 서브 도메인 허용

📷 스크린샷

☑️ 체크 리스트

체크 리스트를 확인해주세요

  • 테스트는 잘 통과했나요?
  • 충돌을 해결했나요?
  • 이슈는 등록했나요?
  • 라벨은 등록했나요?

#️⃣ 연관된 이슈

close #218

💬 리뷰 요구사항

Summary by CodeRabbit

버그 수정

  • 쿠키 도메인 설정을 명시적으로 구성하여 도메인 간 쿠키 처리의 안정성을 개선했습니다.

@marulog marulog self-assigned this Mar 23, 2026
@marulog marulog added the feat 새로운 기능 구현 label Mar 23, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 777f4bc0-0337-427d-bf99-50f4531d0376

📥 Commits

Reviewing files that changed from the base of the PR and between d4203f7 and 55cbaf2.

📒 Files selected for processing (1)
  • modules/common-security/src/main/java/com/ott/common/security/util/CookieUtil.java

Walkthrough

CookieUtil에서 쿠키 생성 및 삭제 메서드의 도메인 설정을 활성화하여 "openthetaste.cloud"로 명시적으로 지정했습니다. 주석 처리된 .domain() 호출을 활성 상태로 변경했으며, 다른 쿠키 속성이나 제어 흐름은 수정되지 않았습니다.

Changes

Cohort / File(s) Summary
쿠키 도메인 설정
modules/common-security/src/main/java/com/ott/common/security/util/CookieUtil.java
addCookie()deleteCookie() 메서드에서 쿠키 도메인을 "openthetaste.cloud"로 명시적으로 설정하는 로직을 활성화했습니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • arlen02-01
  • yubin012
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch OT-369-feature/seperate-JWT

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@marulog marulog merged commit da459dc into develop Mar 23, 2026
1 check was pending
@phonil phonil deleted the OT-369-feature/seperate-JWT branch April 4, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat 새로운 기능 구현

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OT-369] [FEAT]: 도메인별 토큰 분리

2 participants