Merged
Conversation
개요쿠키 유틸리티에서 도메인 설정을 활성화하고, 보안 속성을 활성화하며, SameSite 속성을 "Lax"에서 "None"으로 변경하여 배포 환경에서의 쿠키 전달을 허용하도록 구성 업데이트. 변경 사항
코드 리뷰 예상 소요 시간🎯 2 (Simple) | ⏱️ ~10분 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@modules/common-security/src/main/java/com/ott/common/security/util/CookieUtil.java`:
- Line 13: Replace the hardcoded .domain("openthetaste.cloud") in CookieUtil
with a configurable approach: read the cookie domain from
configuration/environment (e.g., an injected property or System.getenv) and only
call builder.domain(domain) when the value is non-empty; if the config is
missing/blank, omit setting the domain so local/staging default behavior
remains. Locate both occurrences in CookieUtil (the two
.domain("openthetaste.cloud") calls around lines shown) and change them to use
the injected/configured domain variable with a conditional check before applying
.domain(...). Ensure the property name is clear (e.g., cookie.domain) and add a
brief unit/integration check to confirm cookies work when the property is unset.
5 tasks
This was referenced Mar 22, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
📷 스크린샷
☑️ 체크 리스트
#️⃣ 연관된 이슈
close #93
💬 리뷰 요구사항
딱히 없습니다.
Summary by CodeRabbit
버그 수정