Skip to content

[OT-169][feat]: 쿠키 secure 옵션 변경#94

Merged
marulog merged 1 commit intodevelopfrom
OT-169-deploy/security-config
Mar 3, 2026
Merged

[OT-169][feat]: 쿠키 secure 옵션 변경#94
marulog merged 1 commit intodevelopfrom
OT-169-deploy/security-config

Conversation

@marulog
Copy link
Copy Markdown
Collaborator

@marulog marulog commented Mar 3, 2026

📝 작업 내용

이번 PR에서 작업한 내용을 적어주세요

  • 쿠키 secure 설정 변경
  • sub domain 설정

📷 스크린샷

☑️ 체크 리스트

체크 리스트를 확인해주세요

  • 테스트는 잘 통과했나요?
  • 충돌을 해결했나요?
  • 이슈는 등록했나요?
  • 라벨은 등록했나요?

#️⃣ 연관된 이슈

close #93

💬 리뷰 요구사항

딱히 없습니다.

Summary by CodeRabbit

버그 수정

  • 쿠키 보안 설정 강화: 안전한 속성 활성화 및 도메인 설정 추가
  • 크로스사이트 쿠키 전송 정책 업데이트

@marulog marulog requested a review from arlen02-01 March 3, 2026 05:18
@marulog marulog self-assigned this Mar 3, 2026
@marulog marulog added the deploy 프로젝트 배포 관련 label Mar 3, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 3, 2026

개요

쿠키 유틸리티에서 도메인 설정을 활성화하고, 보안 속성을 활성화하며, SameSite 속성을 "Lax"에서 "None"으로 변경하여 배포 환경에서의 쿠키 전달을 허용하도록 구성 업데이트.

변경 사항

Cohort / File(s) Summary
쿠키 보안 설정
modules/common-security/src/main/java/com/ott/common/security/util/CookieUtil.java
addCookie 및 deleteCookie 메서드에서 도메인 설정 활성화, 보안 속성 활성화(true로 변경), SameSite 속성을 "None"으로 변경.

코드 리뷰 예상 소요 시간

🎯 2 (Simple) | ⏱️ ~10분

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목은 쿠키 secure 옵션 변경을 명확하게 설명하며 변경사항의 주요 내용을 잘 반영합니다.
Linked Issues check ✅ Passed PR은 연결된 이슈 #93의 '쿠키 설정 변경' 요구사항을 충족하며, CookieUtil에서 secure, domain, sameSite 속성을 업데이트했습니다.
Out of Scope Changes check ✅ Passed 모든 변경사항은 배포 환경에서의 쿠키 전달을 허용하기 위한 쿠키 속성 수정으로 이슈 #93의 범위 내에 있습니다.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch OT-169-deploy/security-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@arlen02-01 arlen02-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 했습니다!

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@modules/common-security/src/main/java/com/ott/common/security/util/CookieUtil.java`:
- Line 13: Replace the hardcoded .domain("openthetaste.cloud") in CookieUtil
with a configurable approach: read the cookie domain from
configuration/environment (e.g., an injected property or System.getenv) and only
call builder.domain(domain) when the value is non-empty; if the config is
missing/blank, omit setting the domain so local/staging default behavior
remains. Locate both occurrences in CookieUtil (the two
.domain("openthetaste.cloud") calls around lines shown) and change them to use
the injected/configured domain variable with a conditional check before applying
.domain(...). Ensure the property name is clear (e.g., cookie.domain) and add a
brief unit/integration check to confirm cookies work when the property is unset.

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ae8653 and a1c3f9e.

📒 Files selected for processing (1)
  • modules/common-security/src/main/java/com/ott/common/security/util/CookieUtil.java

@marulog marulog merged commit 716722f into develop Mar 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy 프로젝트 배포 관련

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OT-169] [DEPLOY]: 배포 설정 파일 변경

2 participants