Skip to content

Attempt assistance for new scripts.#1851

Merged
Martii merged 1 commit intoOpenUserJS:masterfrom
Martii:Issue-944attemptAssistanceNewScript
Nov 21, 2021
Merged

Attempt assistance for new scripts.#1851
Martii merged 1 commit intoOpenUserJS:masterfrom
Martii:Issue-944attemptAssistanceNewScript

Conversation

@Martii
Copy link
Copy Markdown
Member

@Martii Martii commented Nov 21, 2021

  • Doesn't matter if we are in lockdown or not for this.
  • NOTE: On dev this didn't work except under Linux SeaMonkey 2.53.8.1 but not Chromium and Fx 94.0.1. Could be a jQuery dep issue or even a browser issue that appeared... or perhaps something changed scope wise. Commented where it happens. This is better than nothing imho. Maybe it will work under pro and perhaps Windows. *shrugs*
  • This feature is very BETA due to the issue encountered in other browsers. Any suggestions are welcome.

Post #1847

* Doesn't matter if we are in lockdown or not for this.
* NOTE: On dev this didn't work except under Linux SeaMonkey 2.53.8.1 but not Chromium and Fx 94.0.1. Could be a jQuery dep issue or even a browser issue that appeared... or perhaps something changed scope wise. Commented where it happens. This is better than nothing imho. Maybe it will work under pro and perhaps Windows. \*shrugs\*
* This feature is very BETA due to the issue encountered in other browsers. Any suggestions are welcome.

Post OpenUserJS#1847
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. labels Nov 21, 2021
@Martii Martii merged commit 288eb20 into OpenUserJS:master Nov 21, 2021
@Martii Martii deleted the Issue-944attemptAssistanceNewScript branch November 21, 2021 06:05
@Martii
Copy link
Copy Markdown
Member Author

Martii commented Nov 21, 2021

Fx logging (pre with failure post):

GEThttps://openuserjs.org/scripts/Marti/oujs_-_Meta_View/source
[HTTP/1.1 200 OK 566ms]

AbortError: Actor 'Conduits' destroyed before query 'RuntimeMessage' was resolved ConduitsParent.jsm:312
Promise resolved while context is inactive
content-utils.js:28
sendRemoveListener on closed conduit {7a7a4a92-a2a0-41d1-9fd7-1e92480d612d}.412316860445 ConduitsChild.jsm:108
GEThttps://openuserjs.org/redist/npm/jquery/dist/jquery.js
[HTTP/1.1 200 OK 0ms]

GEThttps://openuserjs.org/redist/npm/bootstrap/dist/js/bootstrap.js
[HTTP/1.1 200 OK 0ms]

GEThttps://openuserjs.org/redist/npm/clipboard/dist/clipboard.js
[HTTP/1.1 200 OK 0ms]

GEThttps://openuserjs.org/redist/npm/ace-builds/src/ace.js
[HTTP/1.1 304 Not Modified 59ms]

GEThttps://openuserjs.org/redist/npm/js-beautify/js/lib/beautify.js
[HTTP/1.1 200 OK 0ms]

GEThttps://openuserjs.org/redist/npm/diff/dist/diff.js
[HTTP/1.1 200 OK 0ms]

GEThttps://openuserjs.org/redist/npm/jquery/dist/jquery.js

GEThttps://openuserjs.org/redist/npm/bootstrap/dist/js/bootstrap.js

GEThttps://openuserjs.org/redist/npm/ace-builds/src/ace.js

GEThttps://openuserjs.org/redist/npm/ace-builds/src/ace.js
[HTTP/1.1 304 Not Modified 57ms]

GEThttps://openuserjs.org/redist/npm/ace-builds/src/ace.js

GEThttps://openuserjs.org/images/favicon.ico
[HTTP/1.1 200 OK 0ms]

GEThttps://openuserjs.org/redist/npm/ace-builds/src/theme-dawn.js
[HTTP/1.1 304 Not Modified 58ms]

GEThttps://openuserjs.org/redist/npm/ace-builds/src/mode-javascript.js
[HTTP/1.1 304 Not Modified 119ms]

GEThttps://openuserjs.org/redist/npm/ace-builds/src/worker-javascript.js
[HTTP/1.1 304 Not Modified 59ms]

@Martii
Copy link
Copy Markdown
Member Author

Martii commented Nov 21, 2021

Edge to the rescue?

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/toSource#browser_compatibility

... something to refix. Probably what is happening... stand by.

Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jan 10, 2022
* Ace is referenced in clipboard but not defined until scriptEditor script is loaded... scoot that around.
* Fix injection into the incorrect pages with *mu2* *(mustache checks)* scope checks

Post OpenUserJS#1851
@Martii Martii mentioned this pull request Jan 10, 2022
Martii added a commit that referenced this pull request Jan 10, 2022
* Ace is referenced in clipboard but not defined until scriptEditor script is loaded... scoot that around.
* Fix injection into the incorrect pages with *mu2* *(mustache checks)* scope checks

Post #1851

Auto-merge
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.

Development

Successfully merging this pull request may close these issues.

1 participant