Fix enforcing of limit QS fix for non-numerics in limitRange#539
Merged
Martii merged 1 commit intoOpenUserJS:masterfrom Jan 15, 2015
Merged
Fix enforcing of limit QS fix for non-numerics in limitRange#539Martii merged 1 commit intoOpenUserJS:masterfrom
limit QS fix for non-numerics in limitRange#539Martii merged 1 commit intoOpenUserJS:masterfrom
Conversation
* A STYLEGUIDE.md enforcement ... 100 character limit * Change function parms to include default value into the function since this should always be under our jurisdiction... **minimal** change in existing templateHelper.js logic. * Use ES5 strict compatible `NaN` conditional test See also https://openuserjs.org/users/sizzle/comments#comment-148579ad751
Martii
added a commit
that referenced
this pull request
Jan 15, 2015
Fix enforcing of `limit` QS fix for non-numerics in `limitRange` Auto-merge
Martii
added
CODE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NaNconditional testSee also https://openuserjs.org/users/sizzle/comments#comment-148579ad751