Update *bootstrap* dep to latest #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `z-index` was the culprit for previously mentioned modal failure * Watchpoint for *bootstrap* 3.1.1 changes to 3.3.1 ... if necessary will swap out entire modal sections of CSS with upstream as they do work and are more compact but reserving that task for OpenUserJS#249 Closes OpenUserJS#379
Martii
added a commit
that referenced
this pull request
Jan 15, 2015
Update *bootstrap* dep to latest Auto-merg
Martii
added
the
migration
Martii
added
CODE
Member
Author
|
Rolling back to 0.1.6-37 on pro. Comment popup wants to self-hide again. Added needs mitigation to #379. |
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Jan 16, 2015
* Not our CSS interfering * Would appear that current *bootstrap-markdown* and current *bootstrap* aren't playing nice with `collapse`. e.g. comment reply box shows however it immediately closes itself. I have seen this behavior before a few times but usually a browser restart handled it... not this time. *bootstrap* 3.2.0, 3.3.0 and 3.3.1 all exhibit this behavior * Leaving `z-index` fix in as 3.1.1 appears not to need this from testing. Refs OpenUserJS#540 and OpenUserJS#379
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Jan 16, 2015
* Not our CSS interfering * jQuery event listeners tested... okay * Would appear that current *bootstrap-markdown* and current *bootstrap* aren't playing nice with `collapse`. e.g. comment reply box shows however it immediately closes itself. I have seen this behavior before a few times but usually a browser restart handled it... not this time. *bootstrap* 3.2.0, 3.3.0 and 3.3.1 all exhibit this behavior * Leaving `z-index` fix in as 3.1.1 appears not to need this from testing. Refs OpenUserJS#540 and OpenUserJS#379
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z-indexwas the culprit for previously mentioned modal failureCloses #379