Skip to content

Conversation

@Martii
Copy link
Member

@Martii Martii commented Jan 16, 2015

  • Not our CSS interfering ... hmmm actually it is our static CSS but not LESS CSS
  • jQuery event listeners tested... okay
  • Would appear that current bootstrap-markdown and current bootstrap aren't playing nice with collapse. e.g. comment reply box shows however it immediately closes itself ... (CORRECTION: height is no longer smart enough to change to auto so have to tell it or use CSS default ) (incorrectly I might add). I have seen this behavior before a few times but usually a browser restart handled it... not this time. bootstrap 3.2.0, 3.3.0, 3.3.1, and 3.3.2 all exhibit this behavior
  • Leaving z-index fix in as 3.1.1 appears not to need this from testing.

Refs #540 and #379

* Not our CSS interfering
* jQuery event listeners tested... okay
* Would appear that current *bootstrap-markdown* and current *bootstrap* aren't playing nice with `collapse`. e.g. comment reply box shows however it immediately closes itself. I have seen this behavior before a few times but usually a browser restart handled it... not this time. *bootstrap* 3.2.0, 3.3.0 and 3.3.1 all exhibit this behavior
* Leaving `z-index` fix in as 3.1.1 appears not to need this from testing.

Refs OpenUserJS#540 and OpenUserJS#379
Martii added a commit that referenced this pull request Jan 16, 2015
Revert *bootstrap* dep update

Auto-merge
@Martii Martii merged commit 090534f into OpenUserJS:master Jan 16, 2015
@Martii Martii deleted the revertBootstrapDepUpdate branch January 16, 2015 03:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant