Skip to content

Change event capture for reply box and reminders #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Martii merged 1 commit into from
Feb 8, 2015
Merged

Change event capture for reply box and reminders #575

Martii merged 1 commit into from
Feb 8, 2015

Conversation

@Martii
Copy link
Member

@Martii Martii commented Feb 8, 2015

  • If a tab doesn't have focus don't bother doing anything for these e.g. multiple tabs opened don't start the timer and don't pop up the reply box a.k.a not concurrent op but user event driven

Change event capture for reply box and reminders
1be2605 
* If a tab doesn't have focus don't bother doing anything for these e.g. multiple tabs opened don't start the timer and don't pop up the reply box a.k.a not concurrent op but user event driven
@Martii Martii added bug You've guessed it... this means a bug is reported. UI Pertains inclusively to the User Interface. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. labels Feb 8, 2015
Martii added a commit that referenced this pull request Feb 8, 2015
@Martii
Merge pull request #575 from Martii/changeEventCaptureForTabs
51a86eb 
Change event capture for reply box and reminders

Auto-merge
@Martii Martii merged commit 51a86eb into OpenUserJS:master Feb 8, 2015
@Martii Martii deleted the changeEventCaptureForTabs branch February 8, 2015 22:00
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Feb 8, 2015
Browser compatibility fix for Chromium/Chrome based browsers and Oper…
6f7e96e 
…a Presto

* `focus` event doesn't appear to be handled properly in two other browsers so reverting comment reply box handler event... this may invalidate OpenUserJS#575 in browsers that handle this incorrectly. `activate` and `create` do nothing additional in tested browsers... Mozilla rules again. ;)
* Restores ability to comment in those tested browsers without scroll and resize
@Martii Martii mentioned this pull request Feb 8, 2015
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Martii