Some misc client side jQuery fixes#577
Merged
Martii merged 1 commit intoOpenUserJS:masterfrom Feb 9, 2015
Merged
Conversation
* Turn off some init event handlers once they are triggered... applies to reminders and top pagination * Keeping local conditionals in as turning off event handlers take longer than a local scoped variable boolean toggle. * Some STYLEGUIDE.md conformance in these files * Use mustache *(*mu2* package)* to load common, usually unchanging, .js code into local scope since it's shared across these e.g. make a client side library .js * Renamed a few common variables... still plenty readable and easier to manage across the board * jQuery `load` event [is said](http://www.w3schools.com/jquery/event_load.asp) to be deprecated but keeping in for possible backward compatibility * Scoot some comments around... and remove the "jQuery" comment... we already know it's jQuery
Martii
added
CODE
Martii
added a commit
that referenced
this pull request
Feb 9, 2015
Some misc client side jQuery fixes Auto-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadevent is said to be deprecated but keeping in for possible backward compatibility