Restore the "chunked" methodology in getMeta#761
Merged
Martii merged 1 commit intoOpenUserJS:masterfrom Oct 6, 2015
Merged
Conversation
* Rename `aChunks` to `aBufs` to match *node* docs and indicate that is what we are expecting * `.concat` is vague on `totalLength` parameter but in tests with *node* it is `String` length e.g. `1` returns one character currently ... added Watchpoint here * Remove the debug messages for now * Tested on ~112.9KiB User Script... took ~10ms-11ms versus 7ms in debug mode on full Buffers conversion... slower **however** less memory intensive in some use cases especially with larger scripts Applies to OpenUserJS#678 Refs: * https://nodejs.org/api/buffer.html#buffer_class_method_buffer_concat_list_totallength
Martii
added
enhancement
Martii
added a commit
that referenced
this pull request
Oct 6, 2015
Restore the "chunked" methodology in `getMeta` Auto-merge
Martii
added
the
needs testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aChunkstoaBufsto match node docs and indicate that is what we are expecting.concatis vague ontotalLengthparameter but in (simple) tests with node it is (appearing to be)Stringlength e.g.1returns one character currently ... added Watchpoint hereApplies to #678
Refs: