Merged
Conversation
* Convert `flagged` to a multi-state QSP instead of **just** `true`/`false` for the inverse filter ... depends on role * Coerce conditionals to indicate that one is testing `true`/`false` but the value is not necessarily expected to be those * Modify affected views * Create a sub view e.g. includes view to reuse some view code for the "Filters" **NOTES** * More to go but this is the stepping stone for Option 4a Applies to OpenUserJS#641 Tested on dev and local pro
Martii
added
UI
Martii
added a commit
that referenced
this pull request
Oct 20, 2015
Add inverse filter list Auto-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flaggedto a multi-state QSP instead of justtrue/falsefor the inverse filter ... depends on roletrue/falsebut the value is not necessarily expected to be thoseNOTES
Applies to #641
Tested on dev and local pro