Skip to content

Cleanup auth controller file as much as possible#808

Merged
Martii merged 1 commit intoOpenUserJS:masterfrom
Martii:cleanupAuthControllerFile
Nov 6, 2015
Merged

Cleanup auth controller file as much as possible#808
Martii merged 1 commit intoOpenUserJS:masterfrom
Martii:cleanupAuthControllerFile

Conversation

@Martii
Copy link
Copy Markdown
Member

@Martii Martii commented Nov 6, 2015

  • This file isn't fully understood by me at this time but some common patterns were applied
  • Added duplicate code WARNING comment ... loosely related to Security issue with redirect url #609
  • Existing user tested
  • New user, but not completed, tested okay

Originally applies to #262 ... not part of #262 (comment)


Now fully tested with new user creation.

* This file isn't fully understood by me at this time but some common patterns were applied
* Added duplicate code WARNING comment ... loosely related to OpenUserJS#609
* Existing user tested
* New user, but not completed, tested okay

Originally applies to OpenUserJS#262 ... not part of OpenUserJS#262 (comment)
@Martii Martii added migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Nov 6, 2015
Martii added a commit that referenced this pull request Nov 6, 2015
Cleanup auth controller file as much as possible

Auto-merge
@Martii Martii merged commit 0b21107 into OpenUserJS:master Nov 6, 2015
@Martii Martii deleted the cleanupAuthControllerFile branch November 6, 2015 10:40
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.

Development

Successfully merging this pull request may close these issues.

1 participant