Skip to content

Move Date to core/object - #827

Merged
FakeByte merged 1 commit into
masterfrom
move/date
Aug 27, 2026
Merged

Move Date to core/object#827
FakeByte merged 1 commit into
masterfrom
move/date

Conversation

@Spartan322

Copy link
Copy Markdown
Member

Extract core/object/Timespan.hpp from Date.hpp
Move needed constants for Timespan into Timespan class
Expose Timespan constants as transparent Date constants
Split Timespan and Date includes

@Spartan322
Spartan322 requested a review from a team as a code owner August 9, 2026 19:45
@Spartan322 Spartan322 added enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change topic:core Issue that applies to core functions, fundamental to the rest of the module labels Aug 9, 2026
Comment thread src/openvic-simulation/history/diplomacy/WarHistory.hpp Outdated
@Spartan322 Spartan322 added the topic:tests Issue that applies to the tests of the module, whether it be adding or modifying tests label Aug 11, 2026
@Spartan322
Spartan322 force-pushed the move/date branch 2 times, most recently from 0b5cfd0 to 38f1cbe Compare August 19, 2026 20:39
@Spartan322
Spartan322 changed the base branch from master to move/colour August 19, 2026 20:39
Base automatically changed from move/colour to master August 24, 2026 20:09
@Spartan322
Spartan322 force-pushed the move/date branch 2 times, most recently from 042d486 to a870da6 Compare August 26, 2026 14:35
Extract `core/object/Timespan.hpp` from `Date.hpp`
Move needed constants for Timespan into Timespan class
Expose Timespan constants as transparent Date constants
Split Timespan and Date includes
@FakeByte
FakeByte added this pull request to the merge queue Aug 27, 2026
Merged via the queue into master with commit c2b2d65 Aug 27, 2026
9 checks passed
@FakeByte
FakeByte deleted the move/date branch August 27, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change topic:core Issue that applies to core functions, fundamental to the rest of the module topic:tests Issue that applies to the tests of the module, whether it be adding or modifying tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants