fix: harden transformer services per review - #412
Conversation
- plugin construction uses signature inspection instead of a TypeError retry, so a TypeError raised inside a config-accepting constructor propagates instead of triggering a silent no-config fallback - a plugin-supplied cancel_by outside a valid cancellation signal is stripped before merging into context (orchestrator-stamped only) - shutdown() iterates all loaded plugins, not just the execution chain, so plugins excluded by an explicit 'order' list are still shut down - feed_audio/feed_hotword/feed_speech isolate per-plugin failures so a broken feeder does not starve subsequent plugins - AudioTransformersService.transform overlays caller context onto the default context instead of discarding the defaults - DialogTransformersService.transform skips dialog from blacklisted skills (context skill_id checked against blacklisted_skills) - explicit re-export aliases for the tts transformer helpers kept in dialog_transformers for backwards compatibility Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Checking in! Here's how the automated tests are looking. 🧐I've aggregated the results of the automated checks for this PR below. 🔍 LintChecking for any potential issues or concerns. 🔍 ❌ ruff: issues found — see job log 📊 CoverageHow well do we know our own code? 🧠 ✅ 85.2% total coverage Files below 80% coverage (21 files)
Full report: download the ⚖️ License CheckI've checked for any conflicting terms of service. 📜 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 📋 Repo HealthA routine checkup to keep the repo running smoothly. 🏥 ✅ All required files present. Latest Version: ✅ 🏷️ Release PreviewCrystal ball analysis: predicting the next version! 🔮 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
🔨 Build TestsConstruction of your features is officially finished. 🏠 ✅ All versions pass
🔒 Security (pip-audit)I've scanned the dependencies for any hidden surprises. 🔍 ✅ No known vulnerabilities found (65 packages scanned). An automated high-five for your latest changes! 🖐️ |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ovos-utterance-plugin-cancel (and other pre-OVOS-TRANSFORM plugins) signal cancellation with 'canceled' alone. The strict §8.1 pair validation stripped those signals, breaking mid-sentence cancellation in ovos-core (caught by its ovoscope e2e). Honor 'canceled: true' without a reason, defaulting cancel_reason to the spec's universal fallback 'other' and logging a warning nudging plugins to add it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Follow-up to #410 addressing the review findings, all verified against current code:
configkwarg instead of catchingTypeError— aTypeErrorraised inside a config-accepting constructor propagates to the load-error log instead of triggering a silent no-config retry.cancel_bycannot be injected: a plugin-suppliedcancel_byoutside a valid §8.1 cancellation pair is stripped before the context merge (it is orchestrator-stamped only).shutdown()iteratesloaded_plugins, so plugins excluded from an explicit"order"chain still get shut down.feed_audio/feed_hotword/feed_speechwrap each plugin call individually — one broken feeder no longer starves the rest.AudioTransformersService.transformmerges caller context over the default context instead of discarding the defaults when a context is passed.skill_idinblacklisted_skillspasses through untransformed.dialog_transformersuse explicit self-aliases.Each fix has a dedicated unit test.
🤖 Generated with Claude Code