refactor/common_qa_speak#63
Merged
Merged
Conversation
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Apr 19, 2023
move the self.speak call to the skill class where it belongs companion PR OpenVoiceOS/ovos-workshop#63
Codecov Report
@@ Coverage Diff @@
## dev #63 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 33
Lines ? 3049
Branches ? 0
=====================================
Hits ? 0
Misses ? 3049
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Apr 19, 2023
move the self.speak call to the skill class where it belongs companion PR OpenVoiceOS/ovos-workshop#63
NeonDaniel
reviewed
Apr 19, 2023
NeonDaniel
left a comment
NeonDaniel
left a comment
Member
There was a problem hiding this comment.
Looks okay, left a comment on the other PR to add context that CommonQuery handled speech
JarbasAl
force-pushed
the
refactor/common_qa_speak
branch
from
94c9982 to
79c91b8
Compare
Member
Author
|
core PR needs to go first so we can pin version here |
move the self.speak call to the skill class where it belongs a companion PR should remove the hardcoded speak from core
JarbasAl
force-pushed
the
refactor/common_qa_speak
branch
from
a1afd9d to
39350b1
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move the self.speak call to the skill class where it belongs
a companion PR should remove the hardcoded speak from core