Add JRuby 10.0.5.0 and 10.1.0.0 to test matrix#463
Merged
Conversation
Adding JRuby 10 to the test matrix exposed RSpec failures:
* JRuby 10's backtrace format reports module methods unqualified
('stack' instead of 'Puppet::Pops::PuppetStack.stack'), so the
PUPPET_STACK_INSERTION_FRAME regex never matched and PuppetStack
pseudo-frames stopped being interleaved into log backtraces. Broaden
the regex to handle Ruby 3.3 (backtick), Ruby 3.4+ (qualified) and
JRuby 10+ (unqualified) formats.
* The integration specs for agent logging and the RDoc parser depend on
the syslog and rdoc gems, which are restricted to platforms: [:ruby]
in the Gemfile and so are absent on JRuby; skip those describes on
JRuby, matching the existing idiom used elsewhere.
* JRuby 10.1.0.0 raises ArgumentError('string contains null byte')
instead of MRI's 'path name contains null byte' when a filename
contains a NUL; accept either message in the affected json/yaml
specs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Sharpie
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Adding JRuby 10 to the test matrix exposed RSpec failures:
Fix generated by Claude.
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent