Skip to content

raise ArgumentError for root when server is unset - #623

Merged
corporate-gadfly merged 1 commit into
mainfrom
corporate-gadfly-patch-1
Aug 29, 2026
Merged

raise ArgumentError for root when server is unset#623
corporate-gadfly merged 1 commit into
mainfrom
corporate-gadfly-patch-1

Conversation

@corporate-gadfly

@corporate-gadfly corporate-gadfly commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Short description

Checklist

I have:

@corporate-gadfly
corporate-gadfly force-pushed the corporate-gadfly-patch-1 branch 2 times, most recently from f09dada to 7dac778 Compare August 29, 2026 16:53
@corporate-gadfly corporate-gadfly added bug Something isn't working backwards-incompatible This change will lead to a major version bump for the next release labels Aug 29, 2026
@corporate-gadfly
corporate-gadfly force-pushed the corporate-gadfly-patch-1 branch from 7dac778 to 0b98d3c Compare August 29, 2026 16:57
@corporate-gadfly corporate-gadfly changed the title Update deprecation warning message for OpenVox raise ArgumentError for root when server is unset Aug 29, 2026
Comment thread lib/puppet/http/service.rb Outdated
@corporate-gadfly
corporate-gadfly force-pushed the corporate-gadfly-patch-1 branch 3 times, most recently from 70d4be3 to 4800015 Compare August 29, 2026 18:12
- add spec for error message for root when server is unset
- add spec for warning message for non-root when server is unset

Signed-off-by: Corporate Gadfly <haroon.rafique@gmail.com>
Co-authored-by: Jo Rhett <geek@jorhett.com>
@corporate-gadfly
corporate-gadfly force-pushed the corporate-gadfly-patch-1 branch from 4800015 to 4422f57 Compare August 29, 2026 19:05
@corporate-gadfly
corporate-gadfly merged commit 6f6d0cf into main Aug 29, 2026
25 checks passed
@corporate-gadfly
corporate-gadfly deleted the corporate-gadfly-patch-1 branch August 29, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompatible This change will lead to a major version bump for the next release bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants