Skip to content

puppet node: redeclare to identical values is a notice not a warning. - #626

Merged
Sharpie merged 1 commit into
OpenVoxProject:mainfrom
jcpunk:notice-on-equal-redeclare
Sep 2, 2026
Merged

puppet node: redeclare to identical values is a notice not a warning.#626
Sharpie merged 1 commit into
OpenVoxProject:mainfrom
jcpunk:notice-on-equal-redeclare

Conversation

@jcpunk

@jcpunk jcpunk commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Short description

On initial bootstrap my hosts have some issues getting all their classes and parameters sorted. This results in some silly looking logs.

puppetserver.log:2026-09-01T14:51:15.564-05:00 WARN  [qtp1853403919-973] [puppetserver] Puppet The node parameter 'slam_purpose' for node 'slam-monitoring-server' was already set to 'server'. It could not be set to 'server'

Since the resulting node parameter is already server, I'd suggest it isn't a WARNING so much as a NOTICE. Yeah, I should clean this up, but since there is no difference between what was set and what I tried to set, I'd rather log this at a lower severity.

Checklist

I have:

Signed-off-by: Patrick Riehecky <riehecky@fnal.gov>
@jcpunk
jcpunk force-pushed the notice-on-equal-redeclare branch from aa7382c to 97bbc18 Compare September 1, 2026 20:18

@Sharpie Sharpie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@Sharpie
Sharpie merged commit b10e935 into OpenVoxProject:main Sep 2, 2026
20 checks passed
@jcpunk
jcpunk deleted the notice-on-equal-redeclare branch September 2, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants