Use string equality to detect s3.osuosl.org - #120
Merged
Conversation
The `S3_ENDPOINT_URL` is currently set in GitHub Actions workflows as a Secret, even though the URL value is not sensitive in any way. Unfortunately, this restricts which operations can be performed in an `if:` statement. Function calls are disallowed, so this commit swaps use of `contains()` for a string equality match. Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
bastelfreak
approved these changes
Aug 4, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
The
S3_ENDPOINT_URLis currently set in GitHub Actions workflows as a Secret, even though the URL value is not sensitive in any way. Unfortunately, this restricts which operations can be performed in anif:statement. Function calls are disallowed, so this commit swaps use ofcontains()for a string equality match.Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent