Include MONOTONIC_USEC in SystemD reload message - #110
Merged
Conversation
Member
Author
|
Building # tail -f /var/log/puppetlabs/puppetserver/puppetserver.log
...
2026-08-30T00:15:50.493Z INFO [async-mixed-1] [p.t.internal] Sending sd_notify message to NOTIFY_SOCKET "/run/systemd/notify": "RELOADING=1\n"
...
2026-08-30T00:15:55.371Z INFO [async-mixed-1] [p.t.internal] Sending sd_notify message to NOTIFY_SOCKET "/run/systemd/notify": "READY=1\n"
# time systemctl reload puppetserver
Job for puppetserver.service failed.
See "systemctl status puppetserver.service" and "journalctl -xeu puppetserver.service" for details.
real 5m0.128s
user 0m0.001s
sys 0m0.006sRe-building with this patch results in a # tail -f /var/log/puppetlabs/puppetserver/puppetserver.log
...
2026-08-30T00:35:35.450Z INFO [async-mixed-1] [p.t.internal] Sending sd_notify message to NOTIFY_SOCKET "/run/systemd/notify": "RELOADING=1\nMONOTONIC_USEC=197340680966\n"
...
2026-08-30T00:35:40.045Z INFO [async-mixed-1] [p.t.internal] Sending sd_notify message to NOTIFY_SOCKET "/run/systemd/notify": "READY=1\n"
...
# time systemctl reload puppetserver 00:38:47 [50/151]
real 0m4.780s
user 0m0.005s
sys 0m0.002s |
Sharpie
enabled auto-merge
August 30, 2026 16:58
bastelfreak
approved these changes
Aug 30, 2026
This commit adds the `MONOTONIC_USEC` field to the `RELOADING` message sent to SystemD. Omitting this field can cause SystemD to ignore reload messages and return from `systemctl reload` early. See: https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Type= Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
This commit fixes two line-based exceptions to the Eastwood linter's rules against reflection. These exceptions were very fragile as any work to a file that caused line numbers to shift would result in unrelated failures in the lint checks. Both instances now use either type hinting or conditional logic to avoid reflection. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
Sharpie
force-pushed
the
add-usec-to-reload
branch
from
August 30, 2026 19:28
01c4d55 to
0c4176f
Compare
Sharpie
disabled auto-merge
August 30, 2026 19:29
Sharpie
enabled auto-merge
August 30, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This commit adds the
MONOTONIC_USECfield to theRELOADINGmessage sent to SystemD. Omitting this field can cause SystemD to ignore reload messages and return fromsystemctl reloadearly.See: https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Type=
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent