Hide tracing behind 'tracing' feature flag #267
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #52
@0xNeshi You're the macro king. Currently two things are annoying
Annoyingly some imports are only needed due to a macro leading to unused import warnings as well.
So there are a lot of work arounds (i.e. allow unused import) you'll see other quicks.
This also leads to the used_underscore_binding clippy error... which we have to ignore. As its simultaneously being used and not 🔮
Rust analyser sees macro as 'inactive'
Ideally we even import tracing as optional if tracing feature flag is on or off (slightly reducing our package size)- i think its theoretically possible however not sure how to do it.