-
Notifications
You must be signed in to change notification settings - Fork 182
Fix missing dependency for get-versioned-remappings #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR fixes a module resolution error in the published package by extracting the version information from the monolithic OpenZeppelin contracts JSON file into a separate, minimal version-only JSON file and TypeScript declarations. It updates the versioned remappings to source the version from this new file, adds it to package metadata, and includes a test validating the packaged module installation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
|
@SocketSecurity ignore-all |
Fixes #734
Packages a
openzeppelin-contracts-version.jsoninto the NPM package containing only the version field, instead of using a larger JSON file which was intended for the UI only (and which was missing from the NPM package).Also adds a packaging test to ensure the package import works.