Skip to content

Smart account: unmatched signers#656

Merged
brozorec merged 1 commit intosa-payload-digestfrom
sa-match-signers
Mar 25, 2026
Merged

Smart account: unmatched signers#656
brozorec merged 1 commit intosa-payload-digestfrom
sa-match-signers

Conversation

@brozorec
Copy link
Copy Markdown
Collaborator

@brozorec brozorec commented Mar 24, 2026

Fixes #630

PR Checklist

  • Tests
  • Documentation

@brozorec brozorec self-assigned this Mar 24, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 24, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a80c6d8c-ede4-481a-996c-773d4d317d1c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sa-match-signers

Comment @coderabbitai help to get the list of available commands and usage tips.

@brozorec brozorec changed the title panic for unmatched signers Smart account: unmatched signers Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.53%. Comparing base (63a2bd6) to head (b4a8345).
⚠️ Report is 1 commits behind head on sa-payload-digest.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           sa-payload-digest     #656      +/-   ##
=====================================================
+ Coverage              96.17%   96.53%   +0.36%     
=====================================================
  Files                     59       58       -1     
  Lines                   6137     6054      -83     
=====================================================
- Hits                    5902     5844      -58     
+ Misses                   235      210      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brozorec brozorec requested a review from ozgunozerk March 25, 2026 10:21
@brozorec brozorec merged commit 0039356 into sa-payload-digest Mar 25, 2026
7 checks passed
@brozorec brozorec deleted the sa-match-signers branch March 25, 2026 10:44
brozorec added a commit that referenced this pull request Mar 26, 2026
* new sign digest

* Smart account: unmatched signers (#656)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants