fix(builder): adopt viewport-locked shell layout#367
Merged
Conversation
Lock app shell to h-screen overflow-hidden so header and footer are pinned to the viewport. Move overflow-y-auto to the main content area so only page content scrolls independently, consistent with the rwa-wizard shell pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h-screen overflow-hiddenso the header and footer are always pinned to the viewportoverflow-y-autoto the main content area so only page content scrolls independentlyMotivation
The previous layout used
min-h-screenon the outer wrapper, which caused the entire page — including the header, sidebar, and footer — to scroll as one unit. The new pattern (h-screen overflow-hiddenon the shell,overflow-y-autoon the leaf content area) is now consistent across all apps in the monorepo (role-manager, rwa-wizard, openzeppelin-ui examples).Test plan