fix(ci): harden workflows against script injection#391
Merged
Conversation
Extract repeated token-resolution boilerplate into a reusable
auth-token composite action and eliminate ${{ }} interpolation
inside run: blocks across workflows.
- Add .github/actions/auth-token composite for fork-aware token resolution
- Pass NPM_TOKEN and matrix values through env vars in run: blocks
- Add concurrency groups to PR workflows
- Set cancel-in-progress: false on production deployment
- Unify harden-runner to v2.13.0
- Bump pnpm/action-setup to v4.2.0 and setup-node to v4.4.0
- Bump docker/setup-buildx-action to v3.12.0
- Drop continue-on-error on CI test step
- Use app token (instead of GITHUB_TOKEN) in update-dependencies
Supersedes #337, which had diverged from main after #373 removed
publish.yml, update-versions.yml, and the publish-rc job in docker-stg.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The prepare composite was doing a second checkout on top of the one each workflow already runs. Removes it (and the now-unused token input) and drops the auth-token resolution from workflows that only needed it to feed prepare. update-dependencies keeps auth-token since it still feeds peter-evans/create-pull-request. Addresses review feedback on #337. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Matrix values aren't user-controllable, so the CHAIN env-var refactor is out of scope for the hardening PR. Restore the run line and step name to match main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh of #337 against current main. The original PR diverged after #373 removed
publish.yml,update-versions.yml, and thepublish-rcjob indocker-stg.yaml..github/actions/auth-tokencomposite action\${{ }}interpolation insiderun:blocks — pass secrets/contexts throughenv:vars to prevent script injectioncancel-in-progress: falseon production deployment to avoid canceling in-flight releasesharden-runnerto v2.13.0pnpm/action-setupto v4.2.0,actions/setup-nodeto v4.4.0,docker/setup-buildx-actionto v3.12.0continue-on-error: truefrom the CI test stepGITHUB_TOKEN) inupdate-dependenciesPR creationFiles changed
.github/actions/auth-token/action.yml(new) — fork-aware token resolution.github/actions/prepare/action.yml— bump pnpm/setup-node SHAs.github/workflows/ci.yml,check-versions.yml,coverage.yml,dependencies.yml,export-testing.yml,lint.yml,update-dependencies.yml— adoptauth-tokencomposite, move secrets to env vars.github/workflows/docker-prod.yaml,docker-stg.yaml— bump pinned versions, quote shell vars, fix concurrency on prod.github/workflows/scorecard.yml— bump pinned versionsValidated locally with `actionlint 1.7.12` — no warnings.
Test plan
Closes #337.
🤖 Generated with Claude Code