fix(ci): remove extra quote in export-testing workflow token parameter #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collins-w
approved these changes
Aug 12, 2025
pasevin
added a commit
that referenced
this pull request
Aug 12, 2025
pasevin
added a commit
that referenced
this pull request
Aug 12, 2025
* Version Packages * fix(ci): disable husky hooks in update-versions workflow (#97) * chore(common): update export versions * Version Packages * fix(ci): remove extra quote in export-testing workflow token parameter (#98) * Version Packages * fix(ci): checkout proper branch before committing in update-versions workflow (#100) * feat(builder): replace contracts wizard icon with custom SVG (#99) * Version Packages * chore: update export versions --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Aleksandr Pasevin <pasevin@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
pasevin
added a commit
that referenced
this pull request
Aug 14, 2025
* Version Packages * fix(ci): disable husky hooks in update-versions workflow (#97) * chore(common): update export versions * Version Packages * fix(ci): remove extra quote in export-testing workflow token parameter (#98) * Version Packages * fix(ci): checkout proper branch before committing in update-versions workflow (#100) * feat(builder): replace contracts wizard icon with custom SVG (#99) * Version Packages * chore: update export versions * Version Packages * chore: update export versions * fix(builder): correct snapshot update command in export version script - Fix updateSnapshots() to target specific export tests instead of all tests - Ensures changesets bumps update both versions.ts and test snapshots correctly - Prevents snapshot test failures in changesets PRs like #116 * fix(ci): update workflow to commit both versions.ts and snapshot files - Fix update-versions.yml to check for changes in both files - Commit both versions.ts and snapshot files when updating versions - Ensures complete automation of version bumps with correct snapshots * fix(builder): always update snapshots regardless of versions.ts changes - Fix critical logic bug where snapshots weren't updated when versions.ts was already current - Ensures snapshots always match current package versions - Resolves snapshot test failures in changesets PRs like #116 - Snapshots are now updated unconditionally to prevent stale snapshot issues * fix(ci): add build step before snapshot updates in update-versions workflow - Fix CI build dependency issue where snapshot tests fail due to unbuilt packages - Add 'pnpm run build' step before running update-export-versions - Ensures adapter packages are built and available for import during snapshot tests - Resolves 'Failed to resolve entry for package' errors in CI environment * chore: update export versions and test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Aleksandr Pasevin <pasevin@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: oz-release-app[bot] <205211949+oz-release-app[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the export-testing workflow failing due to a syntax error in the token parameter.
Problem
The workflow was failing with git authentication errors:
Root Cause
Line 40 had an extra single quote breaking the token parameter:
Solution
Removed the extra quote:
This syntax error was preventing proper GitHub authentication, causing the workflow to fail.