Environment variables added for slack invites and staging. #59
Environment variables added for slack invites and staging. #59
Conversation
ohaiwalt
left a comment
ohaiwalt
left a comment
There was a problem hiding this comment.
Looked at the issue resolved as well as PR description, lots of unmentioned items in here. Are those intended to be included here?
If so, please update w/descriptions and references.
| secretKeyRef: | ||
| name: backend-secrets | ||
| key: airtable_base_id | ||
| optional: true |
There was a problem hiding this comment.
What's this optional: true doing here? It's not mentioned in the PR. Also for each following reference.
There was a problem hiding this comment.
We aren't using airtable in staging, Without this environment variable set in the config file kubernetes gets mad.
Currently airtable is used as a spreadsheet database for mentor requests.
| secretKeyRef: | ||
| name: backend-secrets | ||
| key: airtable_api_key | ||
| - name: SLACK_LEGACY_ADMIN_TOKEN |
There was a problem hiding this comment.
PR says adding POSTGRES_USER, where'd this come from?
There was a problem hiding this comment.
Initially it was just going to be this. But these variables ended up being required to get the slack invites working. These environment variables were initially stored in a way that made it not obvious they were used. When we deactivated them we forgot they were still in use.
| secretKeyRef: | ||
| name: backend-secrets | ||
| key: slack_subdomain | ||
| - name: SLACK_LEGACY_ADMIN_TOKEN |
There was a problem hiding this comment.
PR says adding POSTGRES_USER, where'd this come from?
| type: Opaque | ||
| data: | ||
| airtable_add_user_base_id: SECRET | ||
| airtable_base_id: SECRET |
There was a problem hiding this comment.
PR says adding POSTGRES_USER, where'd this come from?
apex-omontgomery
changed the title
2 participants
OperationCode/operationcode_backend#458
Already have POSTGRES_PASSWORD, adding
POSTGRES_USERto the deployment file.This PR was work on the environment variables that affected 2 systems:
These changes were related to getting the slack invites working, by moving the credentials into the kubernetes and by specifying which environment variables are optional for kubernetes in staging. Without these values in staging, kubernetes ran into errors where it'd look for them.
https://github.com/OperationCode/operationcode_backend/pull/447/files
These changes have been pushed to prod kubenernetes since Nov 9th in order to unblock @kylemh