Skip to content

Environment variables added for slack invites and staging. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohaiwalt merged 6 commits into from
Apr 19, 2019
Merged

Environment variables added for slack invites and staging. #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c95bcda
add POSTGRES_USER to get the right value
Nov 10, 2018
d631ca3
add postgres_user to template
Nov 10, 2018
7a7cd79
add slack new admin token
Nov 10, 2018
3d228bb
add optional attributes for some keys
Nov 10, 2018
94eabb5
of course I need to add these to redis....
Nov 10, 2018
33087a7
put slack token in redis section also
Nov 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions kubernetes/operationcode_backend/deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,37 +27,52 @@ spec:
secretKeyRef:
name: backend-secrets
key: airtable_api_key
- name: SLACK_LEGACY_ADMIN_TOKEN
Copy link
Member

@ohaiwalt ohaiwalt Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR says adding POSTGRES_USER, where'd this come from?

Copy link
Member Author

@apex-omontgomery apex-omontgomery Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially it was just going to be this. But these variables ended up being required to get the slack invites working. These environment variables were initially stored in a way that made it not obvious they were used. When we deactivated them we forgot they were still in use.

valueFrom:
secretKeyRef:
name: backend-secrets
key: slack_legacy_admin_token
- name: AIRTABLE_BASE_ID
valueFrom:
secretKeyRef:
name: backend-secrets
key: airtable_base_id
optional: true
Copy link
Member

@ohaiwalt ohaiwalt Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this optional: true doing here? It's not mentioned in the PR. Also for each following reference.

Copy link
Member Author

@apex-omontgomery apex-omontgomery Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't using airtable in staging, Without this environment variable set in the config file kubernetes gets mad.

Currently airtable is used as a spreadsheet database for mentor requests.

- name: GIT_HUB_CLIENT_ID
valueFrom:
secretKeyRef:
name: backend-secrets
key: git_hub_client_id
optional: true
- name: GIT_HUB_CLIENT_SECRET
valueFrom:
secretKeyRef:
name: backend-secrets
key: git_hub_client_secret
optional: true
- name: GIT_HUB_OAUTH_TOKEN
valueFrom:
secretKeyRef:
name: backend-secrets
key: git_hub_oauth_token
optional: true
- name: PY_BOT_AUTH_KEY
valueFrom:
secretKeyRef:
name: backend-secrets
key: py_bot_auth_key
optional: true
- name: POSTGRES_HOST
value: opcode-postgres
- name: REDIS_URL
value: redis://opcode-redis:6379/0
- name: RAILS_ENV
value: production
- name: POSTGRES_USER
valueFrom:
secretKeyRef:
name: backend-secrets
key: postgres_user
- name: SLACK_SUBDOMAIN
valueFrom:
secretKeyRef:
Expand Down Expand Up @@ -96,6 +111,11 @@ spec:
secretKeyRef:
name: backend-secrets
key: postgres_password
- name: POSTGRES_USER
valueFrom:
secretKeyRef:
name: backend-secrets
key: postgres_user
- name: POSTGRES_HOST
value: opcode-postgres
- name: REDIS_URL
Expand All @@ -105,6 +125,11 @@ spec:
secretKeyRef:
name: backend-secrets
key: slack_subdomain
- name: SLACK_LEGACY_ADMIN_TOKEN
Copy link
Member

@ohaiwalt ohaiwalt Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR says adding POSTGRES_USER, where'd this come from?

valueFrom:
secretKeyRef:
name: backend-secrets
key: slack_legacy_admin_token
- name: SLACK_TOKEN
valueFrom:
secretKeyRef:
Expand Down
3 changes: 3 additions & 0 deletions kubernetes/operationcode_backend/secrets/secret.yml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,14 @@ metadata:
type: Opaque
data:
airtable_add_user_base_id: SECRET
airtable_base_id: SECRET
Copy link
Member

@ohaiwalt ohaiwalt Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR says adding POSTGRES_USER, where'd this come from?

airtable_add_user_table_name: SECRET
airtable_api_key: SECRET
jwt_secret_key: SECRET
postgres_password: SECRET
postgres_user: SECRET
secret_key_base: SECRET
slack_legacy_admin_token: SECRET
sendgrid_password: SECRET
sendgrid_username: SECRET
sendgrid_api_key: SECRET
Expand Down