fixes #338#341
Merged
aaron-junot merged 2 commits intoOperationCode:mainfrom Jul 5, 2020
Merged
Conversation
aaron-junot
reviewed
Jul 4, 2020
Member
|
Oh, you know what? The CI failed on the tests, not the linting (though I still think we should remove the extra lines). The test that failed checks to make sure that resource ID 1 is the first one returned, which is no longer expected behavior. We should change that test to check for the category to equal "Getting Started" rather than checking the ID. It's probably good to get a unit test around this anyway so that if someone changes the behavior we know about it and it's intentional. If you want to screen share on it to fix the issues we can, just hit me up on slack. |
Collaborator
Author
|
That sounds good to me but I likely won't be around long enough to do it tomorrow. Ill be around Sunday/Monday though. I'll ping you in slack sometime then.
Thanks!
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Aaron Suarez <notifications@github.com>
Sent: Friday, July 3, 2020 11:56:21 PM
To: OperationCode/resources_api <resources_api@noreply.github.com>
Cc: Josh Mills <jtmills09@live.com>; Author <author@noreply.github.com>
Subject: Re: [OperationCode/resources_api] fixes #338 (#341)
Oh, you know what? The CI failed on the tests, not the linting (though I still think we should remove the extra lines).
The test that failed checks to make sure that resource ID 1 is the first one returned, which is no longer expected behavior. We should change that test to check for the category to equal "Getting Started" rather than checking the ID. It's probably good to get a unit test around this anyway so that if someone changes the behavior we know about it and it's intentional.
If you want to screen share on it to fix the issues we can, just hit me up on slack.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#341 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOWFFCUOMXP5RQYNEAAMXZ3RZ2R6LANCNFSM4OQDNUWQ>.
|
Member
|
Enjoy your 4th! I will also likely not be around due to festivities, but we'll sync up soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #338