Raise DBAPIError rather than None#343
Merged
aaron-junot merged 1 commit intomainfrom Jul 6, 2020
Merged
Conversation
Member
Author
|
I did some manual testing in staging and everything looks good to me. These changes didn't affect anything with auth or with creating/updating resources. All the GET requests return the data I'm expecting. So I really think it was just a weird test thing and not anything to worry about in production. I'm going to go ahead and deploy 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we merged #341, the tests started failing on this line
resources_api/app/api/routes/resource_retrieval.py
Line 91 in b4d281c
I'm not sure exactly why this fixes it, but it's more correct anyway and it happens to fix the tests. I'm going to merge it and then do some manual testing on staging and make sure everything is good to go before we deploy to prod.