Skip to content

Raise DBAPIError rather than None #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-junot merged 1 commit into from
Jul 6, 2020
Merged

Raise DBAPIError rather than None #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from app import app
from app import db as _db
from app.utils import standardize_response
from sqlalchemy.exc import DBAPIError

TEST_DATABASE_URI = 'sqlite:///:memory:'

Expand Down Expand Up @@ -190,7 +191,7 @@ def fake_category_query_error(mocker):
Mocks an exception being raised during a query to test error handling
"""

mocker.patch('app.models.Category.query', new=None)
mocker.patch('app.models.Category.query', side_effect=DBAPIError)


@pytest.fixture(scope='function')
Expand All @@ -199,7 +200,7 @@ def fake_language_query_error(mocker):
Mocks an exception being raised during a query to test error handling
"""

mocker.patch('app.models.Language.query', new=None)
mocker.patch('app.models.Language.query', side_effect=DBAPIError)


@pytest.fixture(scope='function')
Expand Down