Use CIRCLE_SHA1 as the image tag instead of BUILD_NUM which is unreliable#349
Merged
aaron-junot merged 1 commit intomainfrom Jul 10, 2020
Merged
Use CIRCLE_SHA1 as the image tag instead of BUILD_NUM which is unreliable#349aaron-junot merged 1 commit intomainfrom
aaron-junot merged 1 commit intomainfrom
Conversation
…able Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
aaron-junot
approved these changes
Jul 10, 2020
| after_build: | ||
| - run: | ||
| name: Tag and Push with $CIRCLE_BUILD_NUM | ||
| name: Tag and Push with $CIRCLE_SHA1 |
Member
There was a problem hiding this comment.
Yeah, Ive always thought it was weird that we used the build number instead of the git SHA. I'm good with this change 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem here: https://app.circleci.com/pipelines/github/OperationCode/resources_api/524/workflows/39d5b471-abef-4067-b6a1-50d021043875/jobs/648
was that using CIRCLE_BUILD_NUM is unreliable because each workflow job will have a new number. This PR proposes using the git commit sha as the tag instead, which is more reliable and traceable back to git!
Signed-off-by: Irving Popovetsky irving@popovetsky.com