Skip to content

Use CIRCLE_SHA1 as the image tag instead of BUILD_NUM which is unreliable #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-junot merged 1 commit into from
Jul 10, 2020
Merged

Use CIRCLE_SHA1 as the image tag instead of BUILD_NUM which is unreliable #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ workflows:
tag: latest
after_build:
- run:
name: Tag and Push with $CIRCLE_BUILD_NUM
name: Tag and Push with $CIRCLE_SHA1
Copy link
Copy Markdown
Member

@aaron-junot aaron-junot Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Ive always thought it was weird that we used the build number instead of the git SHA. I'm good with this change 👍

command: |
IMAGE_ID=operationcode/resources-api
docker tag ${IMAGE_ID}:latest ${IMAGE_ID}:${CIRCLE_BUILD_NUM}
docker push ${IMAGE_ID}:${CIRCLE_BUILD_NUM}
docker tag ${IMAGE_ID}:latest ${IMAGE_ID}:${CIRCLE_SHA1}
docker push ${IMAGE_ID}:${CIRCLE_SHA1}
requires:
- build_test
filters:
Expand All @@ -29,7 +29,7 @@ workflows:

# Deploy the new docker image to the AWS EKS cluster, staging namespace
- aws-eks/update-container-image:
container-image-updates: 'app=operationcode/resources-api:${CIRCLE_BUILD_NUM}'
container-image-updates: 'app=operationcode/resources-api:${CIRCLE_SHA1}'
cluster-name: 'operationcode-backend'
namespace: 'operationcode-staging'
resource-name: 'deployment/resources-api'
Expand Down