fix: report a download in one place, and let a failed one be dismissed - #203
Merged
Conversation
An errored download row had no way out: the store gave completed and cancelled rows a linger but had no case for error, the top right card rendered its button only while a transfer was running, and the bottom right panel never mapped download to a remove action in either its rows or its close button.
A download announced itself as a toast, as a card in the top right, and as a row on the operations card in the bottom right, all at once. The operations card already carried every status the separate card did, so that card and the routine toasts are gone. One toast remains for a failure that never reaches the card, and the row now shows the percentage.
… retry Review of the branch turned up two real gaps. The row drew its trailing control for active, completed and cancelled operations only, so anything that had failed fell through to nothing and had no button at all. And the linger timers removed by file id unconditionally, so retrying inside the window deleted the row of the transfer now running.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…itself Downloads cleared themselves on a timer, which read as tidy until a failure needed the same treatment: a reason that takes itself off the screen is no use to anyone who was not looking, and the panel can be collapsed. Uploads and deletes have always waited to be dismissed, and every settled row now has a button on it, so downloads match them.
Rakesh-46-VR
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A download that hit a network error left a row nothing could remove, so the panel stayed up until the page was reloaded.
Fixed
completedandcancelledrows but no case forerror. It now clears after 8s, and those timers check the row is still the one they were set for, so retrying does not delete the live row.downloadto a remove action, in either the row's remove or the panel's close button. So the X did nothing.Also
How to check
Downloading... 45%.