OrchardCMS retarget to .Net10 failed with ambiguous call error between custom GetKeyedService() and Microsoft.Extensions.DependencyInjection.ServiceProviderKeyedServiceExtensions.GetKeyedService()

[CancanTang]

Describe the bug

When retargeting OrchardCMS app to .NET 10, it is built failed with CS0212 error

The call is ambiguous between the following methods or properties: 'Microsoft.Extensions.DependencyInjection.ServiceProviderKeyedServiceExtensions.GetKeyedService(System.IServiceProvider, System.Type, object?)' and 'OrchardCore.Environment.Shell.Builders.ServiceProviderExtensions.GetKeyedService(System.IServiceProvider, System.Type, object?)'

After investigation , OrchardCore needs to remove their extension method for .NET 10 .
please refer to dotnet/aspnetcore#60307 to get details

Orchard Core version

To Reproduce

1. replace net8.0 to net10.0 in src\OrchardCore.Build\Dependencies.AspNetCore.props file.
2. dotnet publish src\OrchardCore.Cms.Web -f net10.0

Expected behavior

publish successfully

Logs and screenshots

[github-actions]

Thank you for submitting your first issue, awesome! 🚀 We're thrilled to receive your input. If you haven't completed the template yet, please take a moment to do so. This ensures that we fully understand your feature request or bug report. On what happens next, see the docs.

If you like Orchard Core, please star our repo and join our community channels.

[hishamco]

Orchard Core is targeting both .NET 8 & 9, we might look into this once .NET 10.0 is shipped and then upgrade

[sebastienros]

@hishamco We actually can anticipate its release to allow for people to test in .NET 10. For instance people like me who want to provide feedback to the dotnet team before it's too late, or to be able to benchmark OC on the latest bits to ensure there aren't any regressions ... Remember how we found issues with net9 beta months before it shipped. There is a team in MS that checks for instance that all popular applications still work with .NET 10, this bug was initiated from that team: dotnet/aspnetcore#60307

In this specific case we can add a #if NET_10_OR_GREATER (or the 9 equivalent if you prefer) pre-processing check to ensure we are not redefining a method that will eventually ship in net10. This way we are already compatible with 10 even if we don't target it ourselves yet. I will do it if nobody beats me to it.

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

[gvkries]

Fixed by #17652