Using the AdminUrlPrefix setting breaks AdminCulturePicker

[fuzl-llc]

Describe the bug

If you use the AdminUrlPrefix setting, the AdminCulturePicker drop down stops working.

To Reproduce

Downloaded the latest code generation templates and create a fresh Orchard Core site with:

dotnet new occms -o TestSite
dotnet new sln --name Test
dotnet sln add TestSite/TestSite.csproj

Open appsettings.json and add this after the default logging entry:

    "OrchardCore": {
        "OrchardCore_Admin": {
            "AdminUrlPrefix": "blah"
        }
    }

Open and run Test.sln, create a new site with the "Blank" recipe and Sqlite database.

Go to /blah, log in, and then in "Configuration > Features," enable features:

Admin Culture Picker (OrchardCore.Localization.AdminCulturePicker)
Localization (OrchardCore.Localization)

In "Settings > Localization > Cultures," add a second culture, e.g. by selecting "ja (Japanese)" and clicking the "+ Add culture" and "Save" buttons.

A message is displayed saying "Site settings updated successfully." and the default culture is shown in the new culture picker select list at the top right of the page.

Try to select the newly added Japanese culture. The page flickers and neither the site UI nor the drop down change to Japanese.

Close the site. Remove the AdminUrlPrefix setting, run the site, and go to /admin. The drop down now works as expected, changing the culture of the site.

Expected behavior

It should work whether AdminUrlPrefix is being used or not.

Orchard Version

2.1.6

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

[sebastienros]

This view is probably missing the admin prefix when it's creating the links.

[Skrypt]

That Razor page uses a variant of the OptionsEditor. Normally it should render the same thing on that page whether using an AdminUrlPrefix or not. The OptionsEditor only deals with Cultures. Maybe the issue is with the Controller or Driver.

[Skrypt]

There is no issue with the functionality itself.
The issue is that japanese is only translated 27% as stated here:

[Skrypt]

As you can see here I'm using "jasmin" as the admin url prefix and I've successfully changed the UI to french.

The only task to do is to find a contributor that has time to translate everything to japanese.
Or we use a tool to translate everything from Google Translate.
I've built one.

[fuzl-llc]

I don't see the admin culture picker in your screenshot. The issue is that when you enable the admin culture picker, it shows up in the top bar near the right side, but if you select a new culture the selected value in that drop down doesn't stay changed. It just stays/reverts to the default. It isn't that the site's text isn't translated, it is that the dropdown itself doesn't work, i.e. if it is on English and you select Japanese, the dropdown itself stays on English.

[Skrypt]

Ok will try. Got confused by your repro steps.

[fuzl-llc]

No worries, I did mention that both the drop down doesn't change and the site's text translation isn't updated which probably was more info than needed to describe the actual bug, potentially causing the confustion. Thanks!

[Skrypt]

Ok, the issue is that the OrchardCore.Localization module startup ConfigureServices method pass before the OrchardCore.Admin ConfigureService method.

The result is that AdminUrlPrefix returned is always "/Admin" for the AdminCookieCultureProvider.
And for some reason using ConfigureOrder doesn't work.

The issue is that we set the cookie to a distinct path which is then different than /admin
This is why it fails to load the proper culture from the AdminCookieCultureProvider.

[hishamco]

Seems I came late here, @Skrypt, if you're willing to fix the issue, I will remove my assignment to this issue

[Skrypt]

I just quickly tried but did not fix it. Won't have time to work on it. Please fix this if you can.