feat: add widget.get_X and widget.get_Y#27
Merged
Conversation
alrun3
commented
Jan 17, 2026
alrun3
force-pushed
the
get-widget-coords
branch
from
January 17, 2026 10:27
56640a8 to
91c2800
Compare
Owner
|
Replacing GetUnitX with GetWidgetX is no good. The widget variant has been benchmarked to just be straight slower, and 99% of the time you're going to be working with units, not widgets. The approach I initially coded was actually to just duplicate the properties and hide the widget one via the Lastly, I noticed that despite knowing about the GetWidgetX vs GetItemX performance difference, I'm not actually using it in So to summarize what this PR should do:
|
Contributor
Author
|
Cool, so exactly what I asked, but for performance and not UX 😁 |
alrun3
force-pushed
the
get-widget-coords
branch
from
January 17, 2026 11:19
91c2800 to
dc7a2c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adjusts unit.X and unit.Y to use GetWidget{X,Y} to align native calls. You may prefer the unit/item specific calls for jassdoc, in which case I'll happily update