Add a per-player auto pickup toggle command - #3
Merged
Conversation
Auto pickup was an all-or-nothing server setting: once enable-auto-pickup was on, every player with the permission had chopped drops forced into their inventory. Players who want the drops on the ground had no way out. Add /atc autopickup (alias /atc pickup) as a self-only toggle, mirroring the existing /atc toggle. The choice is stored per player in the player_data table so it survives relogs and restarts, and is refused when auto pickup is off server-wide so nobody stores an "on" that does nothing. The new autoPickupEnabled column is added to tables created by older versions via a JDBC-metadata check plus ALTER TABLE, defaulting existing players to on so behaviour does not change under them. New players follow the new defaultAutoPickup config key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto pickup was an all-or-nothing server setting: once enable-auto-pickup was on, every player with the permission had chopped drops forced into their inventory. Players who want the drops on the ground had no way out.
Add /atc autopickup (alias /atc pickup) as a self-only toggle, mirroring the existing /atc toggle. The choice is stored per player in the player_data table so it survives relogs and restarts, and is refused when auto pickup is off server-wide so nobody stores an "on" that does nothing.
The new autoPickupEnabled column is added to tables created by older versions via a JDBC-metadata check plus ALTER TABLE, defaulting existing players to on so behaviour does not change under them. New players follow the new defaultAutoPickup config key.