Support claiming legacy redeem requests#232
Merged
Merged
Conversation
clement-ux
reviewed
May 20, 2026
Contributor
clement-ux
left a comment
There was a problem hiding this comment.
Some comments, but lgtm 👍
clement-ux
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reservedWithdrawLiquidityto a new storage slot and preserve the legacy packed withdrawal queue slot.shares == 0.Details
Legacy asset-denominated LP withdrawal requests can now be claimed after the upgrade instead of requiring the old queue to be fully drained before
upgradeToAndCall.New share-escrowed requests continue to use the new share-based queue accounting, while legacy requests use the preserved
_deprecatedWithdrawsQueued/_deprecatedWithdrawsClaimedcounters.Swap-facing revert strings are intentionally unchanged for compatibility.
Testing
forge test --match-path 'test/unit/OriginARM/{Deposit,RequestRedeem,ClaimRedeem,MigrateLegacyWithdrawQueue}.sol' -vvforge test --match-path 'test/fork/LidoARM/{Deposit,ClaimRedeem}.t.sol' -vvforge test --match-path 'test/deploy/*UpgradeGuards.t.sol' -vvforge build --sizes | rg '(^|\| )(LidoARM|OriginARM|EthenaARM|EtherFiARM|ReentrantGuardHarnessARM) 'git diff --checkContract Sizes