Optimize Ethena unstaker queue tracking#245
Merged
Merged
Conversation
…counter and derive each unstaker index by request position modulo the unstaker count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pendingUnstakerIndexesstorage with atotalRequestscounterrequestIndex % MAX_UNSTAKERStotalRequests()andunstakerIndexAt()Motivation
The pending unstaker index array stored a deterministic repeating sequence based on request position. Since the adapter always rotates from index
0throughMAX_UNSTAKERS - 1, each queued unstaker index can be derived without storing it.Testing
forge buildforge test --match-path test/fork/EthenaARM/RequestWithdraw.t.solforge test --match-path test/fork/EthenaARM/ClaimBaseWithdrawals.t.sol