Add Morpho Aave strategy #1207
Merged
Add Morpho Aave strategy #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahthepro
requested review from
DanielVF,
franckc and
sparrowDom
as code owners
DanielVF
reviewed
Dec 20, 2022
DanielVF
reviewed
Dec 20, 2022
DanielVF
reviewed
Dec 20, 2022
DanielVF
reviewed
Dec 20, 2022
DanielVF
reviewed
Dec 20, 2022
DanielVF
reviewed
Dec 20, 2022
DanielVF
reviewed
Dec 20, 2022
DanielVF
reviewed
Dec 20, 2022
sparrowDom
reviewed
Dec 20, 2022
sparrowDom
reviewed
Dec 20, 2022
Member
sparrowDom
left a comment
sparrowDom
left a comment
There was a problem hiding this comment.
Great job @shahthepro. Seems solid!
I got 1 small consideration whether we should refactor the supportsAsset, _getCTokenFor into something compound and avve strategies might use. Since it seems they currently differ only in the names of the contracts.
Otherwise looks solid 💪
MerlinEgalite
approved these changes
Dec 23, 2022
Comment on lines
13
to
14
| import { StableMath } from "../utils/StableMath.sol"; | ||
| import "../utils/Helpers.sol"; |
Contributor
There was a problem hiding this comment.
I don't think it's used
Contributor
There was a problem hiding this comment.
@shahthepro. We should go ahead and remove this line if it's not used. Will keep the codebase clean.
Collaborator
Author
There was a problem hiding this comment.
Sure, will remove and redeploy the contracts today
5 tasks
DanielVF
approved these changes
Jan 3, 2023
* Deploy Morpho Aave strategy * Update deployment files * prettify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Morpho Aave strategy. Morpho Aave doesn't distribute any reward tokens, so the rewards related functions don't do anything right now.
The deploy script uses Aave v2 tokens and have tested it on fork.
Uses migration ID 046 instead of 045 (since that's used in #1205 for LUSD).
If you made a contract change, make sure to complete the checklist below before merging it in master.
Refer to our documentation for more details about contract security best practices.
Contract change checklist: