Skip to content

[SafeModule] Fix CurvePoolBoosterBribesModule.#2752

Merged
clement-ux merged 1 commit intomasterfrom
clement/fix-curvepb-safemodule
Jan 14, 2026
Merged

[SafeModule] Fix CurvePoolBoosterBribesModule.#2752
clement-ux merged 1 commit intomasterfrom
clement/fix-curvepb-safemodule

Conversation

@clement-ux
Copy link
Copy Markdown
Collaborator

Description

There is a bug, in the current CurvePoolBoosterBribesModule, that block us from removing a pool booster from the list (break is missing at the end of the if, on the for loop).

This PR fix it and deploy a new version of this module.

Contract

Name Address
CurvePoolBoosterBribesModule 0x94aE28576cBD702305F009B70eE6e15De04B0434

Governance

  • Disable old module: 0xb000833E7C140a5359BeF8B92BecBcAE9AaBF64E
  • Enable new module: 0x94aE28576cBD702305F009B70eE6e15De04B0434

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link
Copy Markdown
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up my mess 🙏🏻

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 41.20%. Comparing base (2e116ae) to head (33e06cd).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...tracts/automation/CurvePoolBoosterBribesModule.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2752      +/-   ##
==========================================
+ Coverage   41.02%   41.20%   +0.18%     
==========================================
  Files         126      126              
  Lines        5789     5790       +1     
  Branches     1537     1537              
==========================================
+ Hits         2375     2386      +11     
+ Misses       3412     3402      -10     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the deployed contract

@clement-ux clement-ux merged commit f96b090 into master Jan 14, 2026
12 of 17 checks passed
@clement-ux clement-ux deleted the clement/fix-curvepb-safemodule branch January 14, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants