[CurvePB] Improve CentralRegistry to support CurvePoolBooster. #2765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clement-ux
changed the base branch from
master
to
clement/curvePB-improvement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## clement/curvePB-improvement #2765 +/- ##
================================================================
+ Coverage 1.49% 39.62% +38.12%
================================================================
Files 126 126
Lines 5802 5825 +23
Branches 1542 1546 +4
================================================================
+ Hits 87 2308 +2221
+ Misses 5714 3515 -2199
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clement-ux
requested review from
naddison36,
shahthepro and
sparrowDom
as code owners
sparrowDom
reviewed
Jan 23, 2026
| // drop the last entry | ||
| poolBoosters.pop(); | ||
|
|
||
| // centralRegistry can be address(0) on some chains |
clement-ux
merged commit aa943c5
into
clement/curvePB-improvement
11 of 17 checks passed
clement-ux
added a commit
that referenced
this pull request
Jan 23, 2026
* Refactor campaign management functions to require ETH for bridge fees and streamline reward handling * Add CurvePoolBoosterFactory deployment scripts for Arbitrum and Mainnet * Implement receive function and update campaign management to handle ETH payments * Organize CurvePoolBooster folders. * Fix rounding issues by fetching balance again in fee calculation * Allow _handleFee to proceed with zero balance without reverting * [CurvePB] Improve CentralRegistry to support CurvePoolBooster. (#2765) * Enhance CurvePoolBooster and Factory: Add CurvePoolBoosterPlain. * move curvePB to dedicated folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrates
CurvePoolBoosterFactorywithPoolBoostCentralRegistryfor centralized tracking and event emission of Curve pool boosters.Changes
IPoolBoostCentralRegistry.sol
CurvePoolBoosterPlainto thePoolBoosterTypeenumCurvePoolBoosterFactory.sol
New Storage:
poolBoosters[]- Array of all pool boosters created by this factorycentralRegistry- Reference to the PoolBoostCentralRegistrypoolBoosterFromPool- Mapping from AMM pool to pool booster entryNew Functions:
removePoolBooster(address)- Governor-only, removes a pool booster from trackingpoolBoosterLength()- Returns count of pool boostersgetPoolBoosters()- Returns all pool booster entriesModified:
initialize()- Now accepts_centralRegistryparametercreateCurvePoolBoosterPlain()- Now stores entry and emits events via central registryNotes:
address(0)allowed for chains without registry)