Skip to content

OGVC-02 Consolidation Fee Underpayment Silently Drains Consensus Rewards#2819

Merged
naddison36 merged 3 commits intonicka/consolidationfrom
nicka/consolidation-OGVC-02
Mar 5, 2026
Merged

OGVC-02 Consolidation Fee Underpayment Silently Drains Consensus Rewards#2819
naddison36 merged 3 commits intonicka/consolidationfrom
nicka/consolidation-OGVC-02

Conversation

@naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Mar 3, 2026

Changes

Verify that msg.value covers the total consolidation fees. Track the cumulative fee returned by BeaconConsolidation.request() across the loop in requestConsolidation(), then require that msg.value is at least
equal to the total.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.08%. Comparing base (e2989ef) to head (e6008b5).
⚠️ Report is 1 commits behind head on nicka/consolidation.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           nicka/consolidation    #2819      +/-   ##
=======================================================
+ Coverage                47.06%   47.08%   +0.02%     
=======================================================
  Files                      106      106              
  Lines                     4617     4619       +2     
  Branches                  1268     1269       +1     
=======================================================
+ Hits                      2173     2175       +2     
  Misses                    2441     2441              
  Partials                     3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@naddison36 naddison36 merged commit 7504421 into nicka/consolidation Mar 5, 2026
13 of 17 checks passed
@naddison36 naddison36 deleted the nicka/consolidation-OGVC-02 branch March 5, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant