Skip to content

OGVC-01 ConsolidationController Relies On Offchain Trust Assumptions For Correct Accounting#2825

Merged
naddison36 merged 2 commits intonicka/consolidationfrom
nicka/consolidation-OGVC-01
Mar 5, 2026
Merged

OGVC-01 ConsolidationController Relies On Offchain Trust Assumptions For Correct Accounting#2825
naddison36 merged 2 commits intonicka/consolidationfrom
nicka/consolidation-OGVC-01

Conversation

@naddison36
Copy link
Collaborator

Changes

  • Require that at least MIN_CONSOLIDATION_PERIOD has elapsed since the consolidation was requested before it can be failed
  • Track source validators being consolidated so they can be verified when failConsolidation is called

MIN_CONSOLIDATION_PERIOD has elapsed since the consolidation was requested before it can be failed
@naddison36 naddison36 added the security Security related things label Mar 3, 2026
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.21%. Comparing base (e2989ef) to head (5c3c820).
⚠️ Report is 5 commits behind head on nicka/consolidation.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           nicka/consolidation    #2825      +/-   ##
=======================================================
+ Coverage                47.06%   47.21%   +0.14%     
=======================================================
  Files                      106      106              
  Lines                     4617     4630      +13     
  Branches                  1268     1271       +3     
=======================================================
+ Hits                      2173     2186      +13     
  Misses                    2441     2441              
  Partials                     3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@naddison36 naddison36 removed the security Security related things label Mar 4, 2026
@naddison36 naddison36 merged commit 10ea3fc into nicka/consolidation Mar 5, 2026
14 of 17 checks passed
@naddison36 naddison36 deleted the nicka/consolidation-OGVC-01 branch March 5, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant