Deploy and configure trustee fee collection#543
Merged
Conversation
Author
|
We missed including VaultCore upgrade in deploy-012 so I will add it to this PR... @tomlinton please hold on reviewing this PR. it is not ready. |
added 2 commits
February 2, 2021 18:57
Author
|
@tomlinton @DanielVF This is now ready for review... Thanks :) |
DanielVF
approved these changes
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy script 13 to deploy VaultCore that implements the trustee fees and to configure the trustee fee and address
Also added a helper hardhat task for artificially generating yield on the vault - handy for testing.
I tested on the fork that the trustee account gets yield upon a rebase, using the following sequence: